Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorchJob: Always show warnings when using elasticPolicy.nProcPerNode #2067

Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
Currently, the PyTorchJob webhook shows a warning only when the Job has the .spec.nprocPerNode and the .spec.elasticPolicy.nProcPerNode, but we should always show a warning when using the .spec.elasticPolicy.nProcPerNode.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8692853878

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 35.266%

Totals Coverage Status
Change from base Build 8689573902: 0.005%
Covered Lines: 4373
Relevant Lines: 12400

💛 - Coveralls

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 18, 2024
@google-oss-prow google-oss-prow bot merged commit ffda392 into kubeflow:master Apr 18, 2024
38 checks passed
@tenzen-y tenzen-y deleted the show-warning-pytorchjob-nproc branch April 18, 2024 06:52
ckyuto pushed a commit to ckyuto/training-operator that referenced this pull request Apr 26, 2024
kubeflow#2067)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Weiyu Yen <ckyuto@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants